Regardless of the actual outcome today – whether the Senate actually votes to convict Trump or not – the process of impeachment is sadly failing.
I will say upfront that in my opinion former President Trump is richly deserving of conviction in this impeachment. He devoted a truly astonishing amount energy to manipulating people to betray our basic governing agreements, especially around elections and the transfer of power. He focused on this significantly more than he focused on actually governing, especially after the election. To me, that is a long-term and acute betrayal of his oath of office that accumulates to an impeachable offense. (And other disclaimers: not an attorney, not a Democrat.)
The sad failure I see is that it has become clear that impeachment has no chance, possibly never had a chance, of being useful in holding any office-holder (perhaps especially the president) accountable for anything, ever. The bodies responsible for impeaching, both the House and the Senate, are much too politicized for that. The process is basically useless. We need to figure out a better way of making sure presidents and others are held accountable. And we need to amend the constitution to reflect it. This is one gift former President Trump has given us: as good as our constitution is, we now see that there are some terrible blind spots in it. Those allow and encourage a kind of power-manipulation, partisanship, groupthink, lack of courage, that skew our government and hurt our country. Let’s make it better.